kylebarron commented on code in PR #526:
URL:
https://github.com/apache/arrow-rs-object-store/pull/526#discussion_r2483808105
##########
src/lib.rs:
##########
@@ -1098,6 +1098,106 @@ macro_rules! as_ref_impl {
as_ref_impl!(Arc<dyn ObjectStore>);
as_ref_impl!(Box<dyn ObjectStore>);
+macro_rules! as_ref_generic_impl {
Review Comment:
My understanding of
> if we implement for all `Arc<T>`/`Box<T>`
was that `dyn ObjectStore` already implemented `T`, so if you implement
`impl<T: ObjectStore> ObjectStore for Arc<T>`, then maybe that already covers
`Arc<dyn ObjectStore>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
