nathaniel-d-ef commented on PR #8759: URL: https://github.com/apache/arrow-rs/pull/8759#issuecomment-3480685697
> @nathaniel-d-ef I'll do a deeper review tonight, but if we plan to go this direction, should we also remove the `AvroError` variant from https://github.com/apache/arrow-rs/blob/main/arrow-schema/src/error.rs? > > I never got around to wiring that up before public release. But the original intent was to align `arrow-avro` with `arrow-csv` and `arrow-json`. > > CC: @alamb I see what you mean. I don't feel strongly either way. On the whole we're probably unlikely to use all of the variants here, so if it's preferable to roll this back a bit and implement the `ArrowError::AvroError` instead, I'm happy to go that direction. I mainly didn't want it stuck somewhere in the middle. Your comment on the issue is a good one, perhaps Parquet is more of the odd one out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
