trxcllnt commented on code in PR #320:
URL: https://github.com/apache/arrow-js/pull/320#discussion_r2492856600
##########
src/data.ts:
##########
@@ -351,11 +351,11 @@ class MakeDataVisitor extends Visitor {
}
public visitUtf8View<T extends Utf8View>(props: Utf8ViewDataProps<T>) {
const { ['type']: type, ['offset']: offset = 0 } = props;
- const views = toArrayBufferView(type.ArrayType, props['views']);
- const nullBitmap = toUint8Array(props['nullBitmap']);
- const variadicBuffers = (props['variadicBuffers'] || []).map((buffer)
=> toUint8Array(buffer));
- const length = props['length'] ?? Math.trunc(views.length /
Utf8View.ELEMENT_WIDTH);
- const nullCount = props['nullBitmap'] ? -1 : 0;
+ const views = toArrayBufferView(type.ArrayType, props.views);
Review Comment:
IIRC we have [special
code](https://github.com/apache/arrow-js/blob/main/gulp/closure-task.js#L50-L56)
to enumerate the public field names of our public types and generate an
externs file so closure compiler doesn't mangle them. If you make
`variadicBuffers` a getter, closure compiler shouldn't mangle it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
