GeorgeLeePatterson commented on code in PR #320:
URL: https://github.com/apache/arrow-js/pull/320#discussion_r2494089621
##########
src/data.ts:
##########
@@ -351,11 +351,11 @@ class MakeDataVisitor extends Visitor {
}
public visitUtf8View<T extends Utf8View>(props: Utf8ViewDataProps<T>) {
const { ['type']: type, ['offset']: offset = 0 } = props;
- const views = toArrayBufferView(type.ArrayType, props['views']);
- const nullBitmap = toUint8Array(props['nullBitmap']);
- const variadicBuffers = (props['variadicBuffers'] || []).map((buffer)
=> toUint8Array(buffer));
- const length = props['length'] ?? Math.trunc(views.length /
Utf8View.ELEMENT_WIDTH);
- const nullCount = props['nullBitmap'] ? -1 : 0;
+ const views = toArrayBufferView(type.ArrayType, props.views);
Review Comment:
Excellent, thank you. The mangling was difficult to find in the first place
so I think by this point I may have been cross-eyed. I'll review to see if I
did the same in any other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
