alamb opened a new pull request, #8789: URL: https://github.com/apache/arrow-rs/pull/8789
# Which issue does this PR close? - Builds on https://github.com/apache/arrow-rs/pull/8786 from @etseidl # Rationale for this change @etseidl suggested: > A further optimization would be to change ColumnOrder::get_sort_order to take an Option<&LogicalType>, but that is a breaking API change. # What changes are included in this PR? 1. Deprecate `ColumnOrder::get_sort_order` 2. Add ColumnOrder::sort_order_for_type` that returns the same value # Are these changes tested? Yes by CI Note I was not able to observe any changes in benchmark performance with this, so I am not sure it it worth doing # Are there any user-facing changes? There is a new API but I think there not many people use this (low level) API so the disruption should be minimal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
