alamb commented on code in PR #8789:
URL: https://github.com/apache/arrow-rs/pull/8789#discussion_r2496458585
##########
parquet/src/basic.rs:
##########
@@ -1132,12 +1132,24 @@ pub enum ColumnOrder {
impl ColumnOrder {
/// Returns sort order for a physical/logical type.
+ #[deprecated(
Review Comment:
here is one deprecation
##########
parquet/src/schema/types.rs:
##########
@@ -919,8 +923,15 @@ impl ColumnDescriptor {
///
/// Note that this function will clone the `LogicalType`. If performance
is a concern,
/// use [`Self::logical_type_ref`] instead.
+ #[deprecated(
+ since = "57.0.0",
Review Comment:
```suggestion
since = "57.1.0",
```
##########
parquet/src/schema/types.rs:
##########
@@ -710,6 +710,10 @@ impl BasicTypeInfo {
///
/// Note that this function will clone the `LogicalType`. If performance
is a concern,
/// use [`Self::logical_type_ref`] instead.
+ #[deprecated(
Review Comment:
I just straight up deprecated the non reference version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
