BlakeOrth commented on code in PR #8801:
URL: https://github.com/apache/arrow-rs/pull/8801#discussion_r2504785283
##########
parquet/src/arrow/schema/extension.rs:
##########
@@ -133,3 +146,41 @@ pub(crate) fn logical_type_for_string(field: &Field) ->
Option<LogicalType> {
pub(crate) fn logical_type_for_string(_field: &Field) -> Option<LogicalType> {
Some(LogicalType::String)
}
+
+#[cfg(feature = "geospatial")]
+pub(crate) fn logical_type_for_binary(field: &Field) -> Option<LogicalType> {
+ use parquet_geospatial::{GeographyType, GeometryType};
+
+ match field.extension_type_name() {
+ Some(n) if n == GeometryType::NAME => match
field.try_extension_type::<GeometryType>() {
+ Ok(GeometryType) => Some(LogicalType::Geometry { crs: todo!() }),
+ Err(_e) => None,
+ },
+ Some(n) if n == GeographyType::NAME => match
field.try_extension_type::<GeographyType>() {
Review Comment:
Yes, I've been blissfully ignoring this fact for the time being. Thank you
for pointing out that `planar` equates to Geometry though, I didn't have that
on my radar and probably would have missed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
