paleolimbot commented on code in PR #8801:
URL: https://github.com/apache/arrow-rs/pull/8801#discussion_r2505049287
##########
parquet-geospatial/src/crs.rs:
##########
@@ -0,0 +1,97 @@
+use std::{collections::HashMap, sync::Arc};
+
+use arrow_schema::{Schema, SchemaBuilder};
+use serde_json::{Value, json};
+
+#[derive(Debug)]
+pub enum Crs {
Review Comment:
> We also get some additional strong typing of the crs data, which I
personally prefer.
If you can guarantee this, it's great! I think my point was that the current
implementation (which I know is in the works) doesn't quite do that (e.g.,
there are some common that currently go through `Other(String)` where the
string is actually PROJJSON), so perhaps it would help reduce the scope of the
`Crs` to make it simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
