andishgar commented on code in PR #47969:
URL: https://github.com/apache/arrow/pull/47969#discussion_r2507766242
##########
cpp/src/arrow/array/statistics_test.cc:
##########
@@ -25,12 +25,20 @@
namespace arrow {
-TEST(TestArrayStatistics, NullCount) {
+TEST(TestArrayStatistics, NullCountExact) {
ArrayStatistics statistics;
ASSERT_FALSE(statistics.null_count.has_value());
statistics.null_count = 29;
ASSERT_TRUE(statistics.null_count.has_value());
- ASSERT_EQ(29, statistics.null_count.value());
+ ASSERT_EQ(29, std::get<int64_t>(statistics.null_count.value()));
+}
+
+TEST(TestArrayStatistics, NullCountApproximate) {
+ ArrayStatistics statistics;
+ ASSERT_FALSE(statistics.null_count.has_value());
+ statistics.null_count = 29.0;
+ ASSERT_TRUE(statistics.null_count.has_value());
+ ASSERT_EQ(29.0, std::get<double>(statistics.null_count.value()));
Review Comment:
Another question — I found that `ASSERT_{DOUBLE,FLOAT}_EQ` checks whether
the distance between two floating-point values is within **4 ULPs**, according
to [this
link](https://github.com/google/googletest/blob/085af2cc08600bdb13827ca40261abcbe5048bb5/googletest/include/gtest/internal/gtest-internal.h#L336-L342),However,
I also noticed that there is a more comprehensive function named
`AssertWithinUlp` in `arrow/testing/math.cc`.Shouldn’t we use the Arrow version
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
