pitrou commented on code in PR #47969:
URL: https://github.com/apache/arrow/pull/47969#discussion_r2509097556
##########
cpp/src/arrow/array/statistics_test.cc:
##########
@@ -25,12 +25,20 @@
namespace arrow {
-TEST(TestArrayStatistics, NullCount) {
+TEST(TestArrayStatistics, NullCountExact) {
ArrayStatistics statistics;
ASSERT_FALSE(statistics.null_count.has_value());
statistics.null_count = 29;
ASSERT_TRUE(statistics.null_count.has_value());
- ASSERT_EQ(29, statistics.null_count.value());
+ ASSERT_EQ(29, std::get<int64_t>(statistics.null_count.value()));
+}
+
+TEST(TestArrayStatistics, NullCountApproximate) {
+ ArrayStatistics statistics;
+ ASSERT_FALSE(statistics.null_count.has_value());
+ statistics.null_count = 29.0;
+ ASSERT_TRUE(statistics.null_count.has_value());
+ ASSERT_EQ(29.0, std::get<double>(statistics.null_count.value()));
Review Comment:
> Oh, can we assume that `29.0` literal always generates the same value in
C++? (I didn't know it.)
Yes, definitely. Any literal should always generate the same value on a
given machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
