axreldable commented on PR #885:
URL: https://github.com/apache/arrow-java/pull/885#issuecomment-3510740288

   @lidavidm , thank you for the approval! I added 
`testFixedSizeBinaryFirstInitialization` unit test to show the initialization 
of `key` or `value` writer failure when initialized with `fixedSizeBinary`.
   
   ```
         // require byteWidth parameter for first-time initialization of `key` 
or `value` writers
         assertThrows(NullPointerException.class, () -> 
writer.key().fixedSizeBinary().write(holder1));
         assertThrows(
             NullPointerException.class, () -> 
writer.value().fixedSizeBinary().write(holder2));
         writer.key().fixedSizeBinary(holder1.byteWidth).write(holder1);
         writer.value().fixedSizeBinary(holder2.byteWidth).write(holder2);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to