axreldable commented on PR #885: URL: https://github.com/apache/arrow-java/pull/885#issuecomment-3510791279
I also noticed one more thing [here](https://github.com/axreldable/arrow-java/blob/fix-UnionMapWriter/vector/src/test/java/org/apache/arrow/vector/TestMapVector.java#L1393-L1394). ``` // {null -> [32, 21]} - wrong "for a given entry, the "key" is non-nullable" - todo: it shouldn't work. Should it? ``` It's possible to add a map with `null` key value which contradicts the [doc](https://github.com/apache/arrow-java/blob/main/vector/src/main/java/org/apache/arrow/vector/complex/MapVector.java#L42-L43). ``` ... Also for a given entry, the "key" is non-nullable, however the "value" can be null. ``` It doesn't relate to the change as I can do the same for other types, e.g. for the `bigInt()` writer: `{1 -> 11, null -> 22, 3 -> 33}`. So, maybe it’s worth creating an issue about it. Or let me know if it’s expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
