rluvaton commented on code in PR #8807:
URL: https://github.com/apache/arrow-rs/pull/8807#discussion_r2510708011


##########
arrow-buffer/src/util/bit_chunk_iterator.rs:
##########


Review Comment:
   consider the following (inefficient) code:
   
   ```rust
   let mut index = 0;
   bitwise_bin_op_helper(
        ... some args that are u64 aligned
        |left, right| {
                for each bit in left and right {
                        some_other_array[index] = left_bit & right_bit;
               index += 1;
                }
           return left & right
        }
   )
   ```
   
   before and after your change will give different order of bits on certain 
endians



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to