westonpace commented on code in PR #8807: URL: https://github.com/apache/arrow-rs/pull/8807#discussion_r2527564387
########## arrow-buffer/src/util/bit_chunk_iterator.rs: ########## Review Comment: From a glance it does seem that all current uses of `bitwise_bin_op_helper` would be safe even if the endianess was swapped. It is a difference from the bit chunks implementation so I agree that updating the docs would be good. An example kernel that would fail would be finding the first unset bit in an array, although I'm not sure `bitwise_unary_op_helper` would be a great solution for that anyways since you'd want "break from loop once found" behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
