hhhizzz commented on code in PR #8733:
URL: https://github.com/apache/arrow-rs/pull/8733#discussion_r2511016276
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -934,12 +950,16 @@ impl<T: ChunkReader + 'static>
ParquetRecordBatchReaderBuilder<T> {
let array_reader = ArrayReaderBuilder::new(&reader, &metrics)
.build_array_reader(fields.as_deref(), &projection)?;
- let read_plan = plan_builder
+ let mut plan_builder = plan_builder
.limited(reader.num_rows())
.with_offset(offset)
.with_limit(limit)
- .build_limited()
- .build();
+ .build_limited();
+
+ let preferred_strategy = plan_builder.preferred_selection_strategy();
Review Comment:
I choose `preferred_selection_strategy` because this is just one option
**preferred** by `readPlan`, it will decide the final `strategy` after it
include the page(offset) into consideration.
Here the `sync reader` won't do page skip so the preferred is the final
result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
