alamb commented on code in PR #8733:
URL: https://github.com/apache/arrow-rs/pull/8733#discussion_r2511608078
##########
parquet/src/arrow/arrow_reader/read_plan.rs:
##########
@@ -233,12 +283,12 @@ pub struct ReadPlan {
/// The number of rows to read in each batch
batch_size: usize,
/// Row ranges to be selected from the data source
- selection: Option<VecDeque<RowSelector>>,
+ selection: Option<RowSelectionCursor>,
}
impl ReadPlan {
/// Returns a mutable reference to the selection, if any
- pub fn selection_mut(&mut self) -> Option<&mut VecDeque<RowSelector>> {
+ pub fn selection_mut(&mut self) -> Option<&mut RowSelectionCursor> {
Review Comment:
🤔 it seems like this is a public API (so we can't change its signature)
https://docs.rs/parquet/latest/parquet/arrow/arrow_reader/struct.ReadPlan.html#method.selection_mut
We can get around this by making a function like
```rust
pub fn row_selection_cursor_mut(&mut self) -> Option<&mut
RowSelectionCursor> {
```
And then
```rust
#[deprecated(since = "57.1.0", note = "Use `row_selection_cursor_mut`
instead")]
pub fn selection_mut(&mut self) -> Option<&mut VecDeque<RowSelector>> {
...
```
I am still playing around to see if I can make the RowSelectionCursor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
