alamb commented on code in PR #542:
URL:
https://github.com/apache/arrow-rs-object-store/pull/542#discussion_r2511207810
##########
src/client/token.rs:
##########
@@ -33,15 +35,17 @@ pub(crate) struct TemporaryToken<T> {
/// [`TemporaryToken`] based on its expiry
#[derive(Debug)]
pub(crate) struct TokenCache<T> {
- cache: Mutex<Option<(TemporaryToken<T>, Instant)>>,
+ cache: ArcSwapOption<CacheEntry<T>>,
Review Comment:
> Let me run a benchmark with arc swap vs. RwLock and report back
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
