crepererum commented on PR #542: URL: https://github.com/apache/arrow-rs-object-store/pull/542#issuecomment-3521796272
FWIW: I don't question that `ArcSwap` is better than the plain `Mutex`, but I don't think it's actually necessary. They way the code is written, the same effect can likely be gained using `RwLock`. > It might make sense to look into using a separate threadpool for CPU and IO work. I don't think there's a CPU contention here and IMHO using a threadpool would be totally overkill. The way the code is written clearly has a reader contention for many concurrent requests though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
