liamzwbao commented on code in PR #8803:
URL: https://github.com/apache/arrow-rs/pull/8803#discussion_r2511609636
##########
arrow-array/src/array/list_array.rs:
##########
@@ -110,11 +110,11 @@ impl OffsetSizeTrait for i64 {
/// ┌─────────────┐ ┌───────┐ │ ┌───┐ ┌───┐ ┌───┐
┌───┐
/// │ [A,B,C] │ │ (0,3) │ │ 1 │ │ 0 │ │ │ 1 │ │
A │ │ 0 │
/// ├─────────────┤ ├───────┤ │ ├───┤ ├───┤ ├───┤
├───┤
-/// │ [] │ │ (3,3) │ │ 1 │ │ 3 │ │ │ 1 │ │
B │ │ 1 │
+/// │ [] (empty) │ │ (3,3) │ │ 1 │ │ 3 │ │ │ 1 │ │
B │ │ 1 │
/// ├─────────────┤ ├───────┤ │ ├───┤ ├───┤ ├───┤
├───┤
/// │ NULL │ │ (3,4) │ │ 0 │ │ 3 │ │ │ 1 │ │
C │ │ 2 │
/// ├─────────────┤ ├───────┤ │ ├───┤ ├───┤ ├───┤
├───┤
-/// │ [D] │ │ (4,5) │ │ 1 │ │ 4 │ │ │ ? │ │
? │ │ 3 │
+/// │ [D] │ │ (4,5) │ │ 1 │ │ 4 │ │ │ 0 │ │
? │ │ 3 │
Review Comment:
This change is to make it consistent with line 152, but probably unnecessary
as
> the nullability of the ListArray is defined by its own null mask (not the
null mask of the child)
Perhaps changing the one on line 152 as `?` makes more sense?
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
