rok commented on code in PR #47609:
URL: https://github.com/apache/arrow/pull/47609#discussion_r2511684594
##########
.github/workflows/python.yml:
##########
@@ -138,6 +138,17 @@ jobs:
continue-on-error: true
run: archery docker push ${{ matrix.image }}
+ - name: Type check with mypy and pyright
+ run: |-
+ python -m pip install mypy pyright ty griffe libcst pytest
hypothesis fsspec scipy-stubs pandas-stubs types-python-dateutil types-psutil
types-requests griffe libcst sphinx types-cffi
+ pip install -i
https://pypi.anaconda.org/scientific-python-nightly-wheels/simple pyarrow
Review Comment:
Indeed. I've added
[/arrow/ci/scripts/python_test_type_annotations.sh](https://github.com/apache/arrow/blob/00047e4caa4cf080080c32c5e10326ee2afec471/ci/scripts/python_test_type_annotations.sh)
(and
[windows](https://github.com/apache/arrow/blob/00047e4caa4cf080080c32c5e10326ee2afec471/ci/scripts/python_test_type_annotations.bat)
equivalents) to call from `compose.yaml`:
https://github.com/apache/arrow/blob/00047e4caa4cf080080c32c5e10326ee2afec471/compose.yaml#L935-L945
and python.yaml:
https://github.com/apache/arrow/blob/00047e4caa4cf080080c32c5e10326ee2afec471/.github/workflows/python.yml#L242-L246
https://github.com/apache/arrow/blob/00047e4caa4cf080080c32c5e10326ee2afec471/.github/workflows/python.yml#L304-L307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
