dangotbanned commented on PR #47609: URL: https://github.com/apache/arrow/pull/47609#issuecomment-3547146166
https://github.com/apache/arrow/pull/47609#issuecomment-3445160090 > I'll try to do another pass sometime next week and ask for a review on the discussions thread, but meanwhile feel free to do pass if you can spare the time :D Sorry for the delay on getting back to you @rok! I've been putting in a lot of time working with `pyarrow` in (https://github.com/narwhals-dev/narwhals/pulls?q=sort%3Aupdated-desc+is%3Apr+%22%28expr-ir%29%2F%22+in%3Atitle) and collecting more issues along the way 🙂 Some fairly high-level things that might be worth checking: - Are all of the APIs in #48117 now in the stubs? - IIRC, some of those were added in this PR - but I think there may still be gaps - Does every `pyarrow.compute` function that is annotated with `Expression` *actually* support them? - The description provided in [acero/user_guide.html#project](https://arrow.apache.org/docs/cpp/acero/user_guide.html#project) appears to rule out everything that isn't listed in [compute/element-wise-scalar-functions](https://arrow.apache.org/docs/cpp/compute.html#element-wise-scalar-functions) - If you're able to remove `Expression` from functions that never accept or return them at runtime; maybe the stubs would shrink a bit? 😄 I'll try to dive into some more specific cases soon in a review - so this is just homework for you if you wanted it for now 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
