BlakeOrth commented on code in PR #8801:
URL: https://github.com/apache/arrow-rs/pull/8801#discussion_r2512137046


##########
parquet-geospatial/src/crs.rs:
##########
@@ -0,0 +1,59 @@
+use std::{collections::HashMap, sync::Arc};
+
+use arrow_schema::{Schema, SchemaBuilder};
+use serde::{Deserialize, Serialize};
+
+#[derive(Debug, Default, Serialize, Deserialize)]
+pub struct Crs {
+    crs: Option<String>,
+    crs_type: Option<String>,
+}
+
+impl Crs {
+    // TODO: make fallible
+    fn try_from_parquet_str(crs: &str, metadata: &HashMap<String, String>) -> 
Self {

Review Comment:
   This method has functionally changed to only detect the case where the 
metadata is in the form of `{"crs": "projjson:<metadata key>"}` and pass 
through all other cases as their raw string value(s) to be handled at a higher 
level. This CRS format is the only one where the CRS metadata isn't fully 
contained in the raw string value, so some minor intervention is still 
necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to