klion26 commented on PR #8825: URL: https://github.com/apache/arrow-rs/pull/8825#issuecomment-3540248411
@scovich Thanks for the review and sorry for the late reply; I had to handle some unforeseen circumstances last week. I've addressed the comments in the new commit. Please take another look. In the last commit, I assumed that before `append_null` here, it can't be accepted as the target type is `Null`(we can't distinguish the target type and the missing element), but it seems `append_null` when `value.as_null.is_none()` in safe mode is fine(we may don't need to distinguish the two types, and there is no null mask in NullArray). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
