scovich commented on code in PR #8825:
URL: https://github.com/apache/arrow-rs/pull/8825#discussion_r2539310678
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -696,24 +696,32 @@ impl VariantToBinaryVariantArrowRowBuilder {
}
}
-struct FakeNullBuilder(NullArray);
+struct FakeNullBuilder {
+ item_count: usize,
+}
impl FakeNullBuilder {
- fn new(capacity: usize) -> Self {
- Self(NullArray::new(capacity))
+ fn new() -> Self {
+ Self { item_count: 0 }
+ }
Review Comment:
tiny nit: Consider `#[derive(Default)]` and `FakeNullBuilder::default()` at
L723 below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
