andishgar commented on issue #48123: URL: https://github.com/apache/arrow/issues/48123#issuecomment-3540521926
>Which method exactly? Enable it in the `Equals` method and add an option in `arrow::EqualOptions` to specify whether it should be included in the comparison. If both `atol` and `ULPs` are used together, perform a bitwise `OR` operation between them >Which problem are you trying to solve? There are two problems: 1-As shown[ here in case 1](https://github.com/apache/arrow/issues/48123#issuecomment-3537362579) ,the current code cannot handle ULPs between floats with different signs. 2-As mentioned in [this Boost issue](https://github.com/boostorg/math/issues/359), the current approach (which seems similar to the Boost version) is very slow when comparing large numbers of float, compared to using simple arithmetic operations on the uint representation (the approach suggested in the blog and implemented in GTest). Note that in the Boost issue mentions this approach cannot handle the problem of different signs; however, the GTest implementation does address this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
