pitrou commented on issue #48123: URL: https://github.com/apache/arrow/issues/48123#issuecomment-3540539325
> 1-As shown[ here in case 1](https://github.com/apache/arrow/issues/48123#issuecomment-3537362579) ,the current code cannot handle ULPs between floats with different signs. I'm not sure I agree with this interpretation. I don't think floats with different signs should be considered equal, even approximately. > the current approach (which seems similar to the Boost version) is very slow when comparing large numbers of float Did you measure it? On which benchmark? If there's a faster version that gives similar results then why not. But this seems a bit unrelated to the task for making Float16 comparison "more meaningful". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
