vustef commented on code in PR #8863:
URL: https://github.com/apache/arrow-rs/pull/8863#discussion_r2539046954
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -625,12 +625,11 @@ impl ArrowReaderOptions {
pub fn with_virtual_columns(self, virtual_columns: Vec<FieldRef>) -> Self {
Review Comment:
Attaching a link for easier discussion:
https://github.com/apache/arrow-rs/pull/8715#discussion_r2535407427
Not having an ability to chain seems a bit degrading, though users can just
use `?` operator for that (in which case it just panics, but that's fine, it's
a choice).
Having a proper builder would be nice, but it's then definitely an API
change, and a bit less quick fix for the main thing that this PR is intended to
solve.
I'm fine with changing to `Result()`. Would you prefer that? Are others on
board?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
