scovich commented on code in PR #8863:
URL: https://github.com/apache/arrow-rs/pull/8863#discussion_r2539299557
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -625,12 +625,11 @@ impl ArrowReaderOptions {
pub fn with_virtual_columns(self, virtual_columns: Vec<FieldRef>) -> Self {
Review Comment:
Why is Result<Self> bad, sorry? Call it `try_with_xxx` if naming conventions
are the problem?
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -625,12 +625,11 @@ impl ArrowReaderOptions {
pub fn with_virtual_columns(self, virtual_columns: Vec<FieldRef>) -> Self {
Review Comment:
Why is `Result<Self>` bad, sorry? Call it `try_with_xxx` if naming
conventions are the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
