alamb opened a new pull request, #8867: URL: https://github.com/apache/arrow-rs/pull/8867
# Which issue does this PR close? - Follow on to https://github.com/apache/arrow-rs/pull/8715 - related to https://github.com/apache/arrow-rs/pull/8863 # Rationale for this change per https://github.com/apache/arrow-rs/pull/8715#discussion_r2535407427, @scovich rightly says > not a fan of panics It is much better for a user facing API to return an error on invalid input than painc # What changes are included in this PR? 1. Make `ArrowReaderOptions::with_virtual_columns` error rather than panic on invalid input 2. Update tests to match # Are these changes tested? Yes by CI # Are there any user-facing changes? While this is an API change it was introduced in https://github.com/apache/arrow-rs/pull/8715 which has not yet been released. Therefore, we can make this change without breaking semver. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
