alamb commented on code in PR #8867:
URL: https://github.com/apache/arrow-rs/pull/8867#discussion_r2539482563
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -622,20 +622,20 @@ impl ArrowReaderOptions {
/// # Ok(())
/// # }
/// ```
- pub fn with_virtual_columns(self, virtual_columns: Vec<FieldRef>) -> Self {
+ pub fn with_virtual_columns(self, virtual_columns: Vec<FieldRef>) ->
Result<Self> {
Review Comment:
The point of the PR is to change this API to avoid panic'ing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
