Dandandan opened a new pull request, #8868:
URL: https://github.com/apache/arrow-rs/pull/8868
# Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax.
- Closes #NNN.
# Rationale for this change
Removing the bounds check makes a quite big impact on filter performance
```
filter context i32 (kept 1/2)
time: [10.757 µs 10.818 µs 10.921 µs]
change: [−48.453% −48.235% −47.968%] (p = 0.00 <
0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
6 (6.00%) high mild
1 (1.00%) high severe
filter context i32 high selectivity (kept 1023/1024)
time: [6.3936 µs 6.4445 µs 6.5095 µs]
change: [−3.2534% −0.5845% +1.7088%] (p = 0.68 >
0.05)
No change in performance detected.
Found 5 outliers among 100 measurements (5.00%)
5 (5.00%) high severe
filter context i32 low selectivity (kept 1/1024)
time: [134.12 ns 135.27 ns 136.82 ns]
change: [−14.101% −12.837% −11.698%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high severe
filter context i32 w NULLs (kept 1/2)
time: [31.751 µs 32.030 µs 32.421 µs]
change: [−34.482% −33.493% −32.603%] (p = 0.00 <
0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) high mild
3 (3.00%) high severe
Benchmarking filter context i32 w NULLs high selectivity (kept 1023/1024):
Collecting 100 samples in estimated 5.0255 s (646k iterafilter context i32 w
NULLs high selectivity (kept 1023/1024)
time: [7.7275 µs 7.7428 µs 7.7580 µs]
change: [−0.5696% −0.2057% +0.1352%] (p = 0.26 >
0.05)
No change in performance detected.
Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe
Benchmarking filter context i32 w NULLs low selectivity (kept 1/1024):
Collecting 100 samples in estimated 5.0008 s (16M iterationsfilter context i32
w NULLs low selectivity (kept 1/1024)
time: [310.15 ns 311.84 ns 313.43 ns]
change: [−11.840% −11.364% −10.853%] (p = 0.00 <
0.05)
Performance has improved.
```
# What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
# Are these changes tested?
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
# Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
