alamb opened a new pull request, #8872: URL: https://github.com/apache/arrow-rs/pull/8872
# Which issue does this PR close? We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. - Closes #NNN. # Rationale for this change The boolean and bitwise kernels are currently very noisy and sometimes get nonsensical results (e.g. https://github.com/apache/arrow-rs/pull/8854#issuecomment-3549763027) I think this is because they are so fast. For example, Here is an output from a recent run (note the benchmark each takes only nanoseconds group alamb_bitwise_ops main ----- ----------------- ---- and 1.00 272.4±1.45ns ? ?/sec 1.00 273.1±1.36ns ? ?/sec and_sliced 1.00 1096.0±1.60ns ? ?/sec 1.00 1095.1±2.77ns ? ?/sec not 1.00 213.8±0.29ns ? ?/sec 1.00 214.0±0.40ns ? ?/sec not_sliced 1.00 965.6±9.77ns ? ?/sec 1.00 961.8±5.75ns ? ?/sec or 1.00 254.1±0.66ns ? ?/sec 1.01 255.6±0.41ns ? ?/sec or_sliced 1.00 1225.5±2.12ns ? ?/sec 1.00 1226.9±7.43ns ? ?/sec # What changes are included in this PR? 1. Change the array size to 8192 to better match typical sizes used 2. Run each kernel 100 times per criterion iteration to reduce noise # Are these changes tested? I will benchmark then # Are there any user-facing changes? No these are benchmarks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
