alamb commented on code in PR #8872:
URL: https://github.com/apache/arrow-rs/pull/8872#discussion_r2541698949
##########
arrow/benches/bitwise_kernel.rs:
##########
@@ -32,80 +32,140 @@ extern crate arrow;
use arrow::util::bench_util::create_primitive_array;
use arrow::util::test_util::seedable_rng;
+const ARRAY_LEN: usize = 8_192;
+
+// These bitwise kernels are very cheap, so run them many times per Criterion
iteration to
+// try and reduce noise in the benchmarks.
+const RUNS_PER_SAMPLE: usize = 1_000;
+
fn bitwise_array_benchmark(c: &mut Criterion) {
- let size = 64 * 1024_usize;
Review Comment:
We often run these kernels on 8k elements, not 64k elements, so adjust the
benchmark to reflect that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
