Friede80 commented on PR #547: URL: https://github.com/apache/arrow-rs-object-store/pull/547#issuecomment-3554359105
> Is this a breaking change? Or is `self.web_identity_token_file` already seeded with the value of `AWS_WEB_IDENTITY_TOKEN_FILE`? That's a good point. `self.web_identity_token_file` will have the value of `AWS_WEB_IDENTITY_TOKEN_FILE` if the builder is initialized via `from_env()`. This is more consistent with how all of the other `AWS_` env vars are handled. But I think you are right that if someone was depending on these env vars being pulled in even while using `AmazonS3Builder::new()` this would break for them. That feels like an unusual use case, and this feature has existed for such a short period of time, that I doubt it will affect anyone. But I'm happy to document the breaking change somewhere (I'm not sure what the process here is for breaking changes) I _could_ also make it backwards compatible if necessary, but it would then be a weird config option that behaves different than all the others which doesn't seem like a great option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
