alamb commented on code in PR #547:
URL:
https://github.com/apache/arrow-rs-object-store/pull/547#discussion_r2550078495
##########
src/aws/builder.rs:
##########
@@ -1060,10 +1060,9 @@ impl AmazonS3Builder {
(Some(_), None, _) => return
Err(Error::MissingSecretAccessKey.into()),
(None, None, _) => unreachable!(),
}
- } else if let (Ok(token_path), Ok(role_arn)) = (
- std::env::var("AWS_WEB_IDENTITY_TOKEN_FILE"),
- std::env::var("AWS_ROLE_ARN"),
- ) {
+ } else if let (Some(token_path), Some(role_arn)) =
Review Comment:
This change makes sense to me -- thank you @Friede80 and @kylebarron
I double checked that the environment variables are still honored and I
think they will be -- specifically, they will be parsed when creating from the
environment here:
https://github.com/apache/arrow-rs-object-store/blob/1b8ecc7f41eab2a3c2c373f1c2fe21bebe391727/src/aws/builder.rs#L566-L565
https://github.com/apache/arrow-rs-object-store/blob/1b8ecc7f41eab2a3c2c373f1c2fe21bebe391727/src/aws/builder.rs#L491-L494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
