XiangpengHao commented on code in PR #8887:
URL: https://github.com/apache/arrow-rs/pull/8887#discussion_r2543853730
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -208,6 +233,21 @@ fn shredded_get_path(
return Ok(ArrayRef::from(target));
};
+ // Try to return the typed value directly when we have a perfect shredding
match.
+ if !matches!(as_field.data_type(), DataType::Struct(_)) {
+ if let Some(typed_value) = target.typed_value_field() {
+ let types_match = typed_value.data_type() == as_field.data_type();
Review Comment:
Is this probably overly restrictive, `Utf8`, `LargeUtf8`, and `Utf8View`
should be allowed. Maybe check if cast-able.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
