alamb commented on code in PR #8898:
URL: https://github.com/apache/arrow-rs/pull/8898#discussion_r2547765668
##########
parquet/src/file/metadata/mod.rs:
##########
@@ -1882,9 +1882,9 @@ mod tests {
.build();
#[cfg(not(feature = "encryption"))]
- let base_expected_size = 2766;
+ let base_expected_size = 2670;
Review Comment:
it is somewhat smaller, but still pretty big
##########
parquet/src/encryption/decrypt.rs:
##########
@@ -582,7 +582,7 @@ impl PartialEq for FileDecryptor {
impl HeapSize for FileDecryptor {
fn heap_size(&self) -> usize {
self.decryption_properties.heap_size()
- + (Arc::clone(&self.footer_decryptor) as Arc<dyn
HeapSize>).heap_size()
Review Comment:
drive by cleanup -- this was added in
https://github.com/apache/arrow-rs/pull/8671 and the new Arc::clone doesn't
seem to be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
