adamreeve commented on code in PR #8898:
URL: https://github.com/apache/arrow-rs/pull/8898#discussion_r2547857068
##########
parquet/src/encryption/decrypt.rs:
##########
@@ -582,7 +582,7 @@ impl PartialEq for FileDecryptor {
impl HeapSize for FileDecryptor {
fn heap_size(&self) -> usize {
self.decryption_properties.heap_size()
- + (Arc::clone(&self.footer_decryptor) as Arc<dyn
HeapSize>).heap_size()
Review Comment:
I think the issue is `dyn HeapSize` doesn't implement `HeapSize`, but even
if it did the existing HeapSize impl for Arc wouldn't work because you can't
use `std::mem::size_of::<T>()` on an unsized dyn object, and need to use
`std::mem::size_of_val`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
