pitrou commented on code in PR #48192:
URL: https://github.com/apache/arrow/pull/48192#discussion_r2568843279
##########
cpp/src/arrow/util/compression_zstd.cc:
##########
@@ -187,9 +202,14 @@ class ZSTDCodec : public Codec {
DCHECK_EQ(output_buffer_len, 0);
output_buffer = &empty_buffer;
}
-
- size_t ret = ZSTD_decompress(output_buffer,
static_cast<size_t>(output_buffer_len),
- input, static_cast<size_t>(input_len));
+ // Decompression context for ZSTD contains several large heap allocations.
Review Comment:
> Unsure about that - the problematic free-threaded case there is the use of
thread pools within feather/ipc. They'd need a `thread_local` like patterns in
any case. Which means instead of one central `thread_local` there would simply
be one at 3+ code locations instead.
The problem is all those thread locals are as long-lived as the threads
themselves.
What we would need is a non-static `ThreadLocal` class that allows tying the
context lifetime to the Codec instance lifetime, for example.
(this could actually be useful for other purposes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
