pitrou commented on code in PR #48192:
URL: https://github.com/apache/arrow/pull/48192#discussion_r2569353687
##########
cpp/src/arrow/util/compression_zstd.cc:
##########
@@ -187,9 +202,14 @@ class ZSTDCodec : public Codec {
DCHECK_EQ(output_buffer_len, 0);
output_buffer = &empty_buffer;
}
-
- size_t ret = ZSTD_decompress(output_buffer,
static_cast<size_t>(output_buffer_len),
- input, static_cast<size_t>(input_len));
+ // Decompression context for ZSTD contains several large heap allocations.
Review Comment:
By the way, a simpler alternative to this non-static `ThreadLocal` class is
to manage a bounded-size freelist of contexts at the Codec level. This would
probably cut down on implementation complexity, though it would also limit
context reuse if the number of decompressing threads goes above the limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
