hiroyuki-sato commented on code in PR #48285:
URL: https://github.com/apache/arrow/pull/48285#discussion_r2579638308
##########
cpp/src/parquet/arrow/reader_writer_benchmark.cc:
##########
@@ -795,8 +799,8 @@ static void
BM_ReadMultipleRowGroupsGenerator(::benchmark::State& state) {
auto reader =
ParquetFileReader::Open(std::make_shared<::arrow::io::BufferReader>(buffer));
std::unique_ptr<FileReader> unique_reader;
- EXIT_NOT_OK(FileReader::Make(::arrow::default_memory_pool(),
std::move(reader),
- &unique_reader));
+ ASSIGN_OR_ABORT(unique_reader,
Review Comment:
Thanks. Fixed. I used `EXIT_NOT_OK` again.
`ASSIGN_OR_ABORT` used in the following line.
The two macros do not seem to behave the same on failure.
```
ASSIGN_OR_ABORT(auto generator,
arrow_reader->GetRecordBatchGenerator(arrow_reader, rgs,
{0}));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
