kou commented on code in PR #48285:
URL: https://github.com/apache/arrow/pull/48285#discussion_r2608816893
##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -1343,14 +1343,33 @@ Status FileReader::Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
const ArrowReaderProperties& properties,
std::unique_ptr<FileReader>* out) {
- *out = std::make_unique<FileReaderImpl>(pool, std::move(reader), properties);
- return static_cast<FileReaderImpl*>(out->get())->Init();
+ ARROW_ASSIGN_OR_RAISE(*out, Make(pool, std::move(reader), properties));
+ return Status::OK();
}
Status FileReader::Make(::arrow::MemoryPool* pool,
std::unique_ptr<ParquetFileReader> reader,
std::unique_ptr<FileReader>* out) {
- return Make(pool, std::move(reader), default_arrow_reader_properties(), out);
+ ARROW_ASSIGN_OR_RAISE(*out,
+ Make(pool, std::move(reader),
default_arrow_reader_properties()));
+ return Status::OK();
+}
+
+Result<std::unique_ptr<FileReader>> FileReader::Make(
+ ::arrow::MemoryPool* pool, std::unique_ptr<ParquetFileReader>
parquet_reader,
+ const ArrowReaderProperties& properties) {
+ std::unique_ptr<FileReader> reader =
+ std::make_unique<FileReaderImpl>(pool, std::move(parquet_reader),
properties);
+ RETURN_NOT_OK(static_cast<FileReaderImpl*>(reader.get())->Init());
+ return reader;
+}
+
+Result<std::unique_ptr<FileReader>> FileReader::Make(
+ ::arrow::MemoryPool* pool, std::unique_ptr<ParquetFileReader>
parquet_reader) {
+ std::unique_ptr<FileReader> reader = std::make_unique<FileReaderImpl>(
+ pool, std::move(parquet_reader), default_arrow_reader_properties());
+ RETURN_NOT_OK(static_cast<FileReaderImpl*>(reader.get())->Init());
+ return reader;
Review Comment:
```suggestion
return Make(pool, std::move(parquet_reader),
default_arrow_reader_properties());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
