Vishwanatha-HD commented on code in PR #48166:
URL: https://github.com/apache/arrow/pull/48166#discussion_r2589688712
##########
cpp/src/arrow/ipc/message_internal_test.cc:
##########
@@ -74,6 +76,29 @@ TEST(TestMessageInternal, TestByteIdentical) {
0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x66, 0x30, 0x00, 0x00,
0x08, 0x00,
0x0C, 0x00, 0x08, 0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x01,
0x40, 0x00, 0x00, 0x00};
+#else
+ // On Big-endian systems, FlatBuffer serialization can produce slightly
different
+ // output across different platforms and toolchains.
Review Comment:
@pitrou.. With the #48239 getting merged into main, I tried making the
changes to schema as you suggested above, but the testcase is not passing on
s390x..
./debug/arrow-ipc-message-internal-test
--gtest_filter="TestMessageInternal.TestByteIdentical"
Running main() from gmock_main.cc
Note: Google Test filter = TestMessageInternal.TestByteIdentical
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestMessageInternal
[ RUN ] TestMessageInternal.TestByteIdentical
arrow/cpp/src/arrow/testing/gtest_util.cc:241: Failure
Expected equality of these values:
buffer.size()
Which is: 228
expected.size()
Which is: 232
Mismatching buffer size
[ FAILED ] TestMessageInternal.TestByteIdentical (1 ms)
[----------] 1 test from TestMessageInternal (1 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (1 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] TestMessageInternal.TestByteIdentical
1 FAILED TEST
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
