Muon commented on code in PR #562:
URL:
https://github.com/apache/arrow-rs-object-store/pull/562#discussion_r2590954760
##########
src/aws/mod.rs:
##########
@@ -305,89 +365,80 @@ impl ObjectStore for AmazonS3 {
self.client.list_with_delimiter(prefix).await
}
- async fn copy_opts(&self, from: &Path, to: &Path, options: CopyOptions) ->
Result<()> {
- let CopyOptions {
- mode,
- extensions: _,
- } = options;
+ async fn copy(&self, from: &Path, to: &Path) -> Result<()> {
+ // Determine source size to decide between single CopyObject and
multipart copy
+ let head_meta = self
+ .client
+ .get_opts(
+ from,
+ GetOptions {
+ head: true,
+ ..Default::default()
+ },
+ )
+ .await?
+ .meta;
Review Comment:
Should this first try to use CopyObject and then fall back if it fails due
to size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
