Muon commented on code in PR #562:
URL:
https://github.com/apache/arrow-rs-object-store/pull/562#discussion_r2591016847
##########
src/aws/mod.rs:
##########
@@ -101,6 +103,56 @@ impl AmazonS3 {
fn path_url(&self, path: &Path) -> String {
self.client.config.path_url(path)
}
+
+ /// Perform a multipart copy operation
+ async fn copy_multipart(
+ &self,
+ from: &Path,
+ to: &Path,
+ size: u64,
+ mode: CompleteMultipartMode,
+ ) -> Result<()> {
+ // Perform multipart copy using UploadPartCopy
+ let upload_id = self
+ .client
+ .create_multipart(to, PutMultipartOptions::default())
+ .await?;
+
+ // S3 requires minimum 5 MiB per part (except final) and max 10,000
parts
+ let part_size = self.client.config.multipart_copy_part_size;
+
+ let mut parts = Vec::new();
+ let mut offset: u64 = 0;
+ let mut idx: usize = 0;
+ let res = async {
+ while offset < size {
+ let end = std::cmp::min(offset + part_size, size);
Review Comment:
```suggestion
let end = if size - offset <= part_size { size } else {
offset + part_size };
```
Avoids overflow and I think is a little clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
