andishgar commented on PR #48429: URL: https://github.com/apache/arrow/pull/48429#issuecomment-3640668658
@pitrou As I found [here](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0476r2.html#bg), the approach used for `bit_cast` in this PR is perfectly fine. >Attuned developers use aligned_storage with memcpy, avoiding alignment pitfalls and allowing them to bit-cast non->default-constructible types. And here is the reference implementation for `std::bit_cast`. https://github.com/jfbastien/bit_cast/blob/c288208c1a68a329a5839f007200ab2ee2b65073/bit_cast.h#L57-L59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
