andishgar commented on PR #48429:
URL: https://github.com/apache/arrow/pull/48429#issuecomment-3665779798
> Is there any type that you have in mind? There are not many types that are
trivially constructible but don't have a default constructor, IMHO.
@pitrou
Types with the following pattern are trivially copyable but do not have a
default constructor. However, I have not found any such type in Arrow so far.
```cpp
struct A {
explicit A(int a) : a(a) {}
int a;
};
```
What would you suggest here?
1. Close the PR?
2. Add a separate code path depending on the presence of a default
constructor?
3. Or proceed with merging this PR as is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
