raulcd commented on code in PR #48418:
URL: https://github.com/apache/arrow/pull/48418#discussion_r2609761898


##########
cpp/examples/arrow/rapidjson_row_converter.cc:
##########
@@ -585,6 +585,7 @@ arrow::Status DoRowConversion(int32_t num_rows, int32_t 
batch_size) {
     assert(doc["data"]["deleted"].IsBool());
     assert(doc["data"].HasMember("metrics"));
     assert(doc["data"]["metrics"].IsArray());
+#ifndef NDEBUG

Review Comment:
   I don't think I understand why is this necessary for this specific example. 
Is something about those specific asserts that requires the check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to