WillAyd commented on code in PR #48418:
URL: https://github.com/apache/arrow/pull/48418#discussion_r2609940436
##########
cpp/examples/arrow/rapidjson_row_converter.cc:
##########
@@ -585,6 +585,7 @@ arrow::Status DoRowConversion(int32_t num_rows, int32_t
batch_size) {
assert(doc["data"]["deleted"].IsBool());
assert(doc["data"].HasMember("metrics"));
assert(doc["data"]["metrics"].IsArray());
+#ifndef NDEBUG
Review Comment:
In debug mode the asserts are removed, so CI fails with a compilation
warning that the doc variable is defined but unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
