adamreeve commented on code in PR #48451:
URL: https://github.com/apache/arrow/pull/48451#discussion_r2621429320
##########
python/pyarrow/src/arrow/python/arrow_to_pandas.cc:
##########
@@ -2023,9 +2040,9 @@ Status MakeWriter(const PandasOptions& options,
PandasWriter::type writer_type,
CATEGORICAL_CASE(Int16Type);
CATEGORICAL_CASE(Int32Type);
CATEGORICAL_CASE(Int64Type);
- case Type::UINT8:
- case Type::UINT16:
- case Type::UINT32:
+ CATEGORICAL_CASE(UInt8Type);
+ CATEGORICAL_CASE(UInt16Type);
+ CATEGORICAL_CASE(UInt32Type);
case Type::UINT64:
return Status::TypeError(
"Converting unsigned dictionary indices to pandas",
Review Comment:
Can this error message please be updated? It's no longer correct that
unsigned indices are not supported after your change. How about "Converting
UInt64 dictionary indices to pandas is not supported".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
